blackjack4494 / youtube-dlc

Command-line program to download various media from YouTube.com and other sites
https://blackjack4494.github.io/youtube-dlc/
The Unlicense
1.22k stars 13 forks source link

Fix MKV Thumbnail embedding #126

Open Geonode458 opened 4 years ago

Geonode458 commented 4 years ago

If you try to embed Thumbnails in an .mkv container you get "ERROR: Only mp3 and m4a/mp4 are supported for thumbnail embedding for now."

Youtube-dl already has a checked pull request youtube-dl pull: 22659

blackjack4494 commented 4 years ago

@Taurus3ye can you give some sample command you used? It used to work for me when I tested it.
https://github.com/blackjack4494/youtube-dlc/pull/28

Geonode458 commented 4 years ago

@Taurus3ye can you give some sample command you used? It used to work for me when I tested it.

28

youtube-dlc videoURL -f bestvideo+bestaudio -o "[Path]\videos\%(title)s.%(ext)s" --embed-thumbnail

cpz3501 commented 4 years ago

Same error text here, really looking forward for this feature.

cpz3501 commented 4 years ago

It seems that the error only occurs when downloading to a different hard drive than the one with the OS.

Edit: that's the error i got "OSError: [WinError 17] The system cannot move the file to a different disk drive."

blackjack4494 commented 4 years ago

It seems that the error only occurs when downloading to a different hard drive than the one with the OS.

Edit: that's the error i got "OSError: [WinError 17] The system cannot move the file to a different disk drive."

Yes this got actually mentioned in a post. There is actually a simple solution for that (apparently). Also this issue should only occur on Windows.