A little filename tweaking

blackjack4494 / youtube-dlc

Command-line program to download various media from YouTube.com and other sites

https://blackjack4494.github.io/youtube-dlc/

The Unlicense

1.22k stars 13 forks source link

A little filename tweaking #203

Open sheerluck opened 4 years ago

sheerluck commented 4 years ago

[x] I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

[ ] Bug fix
[x] Improvement
[ ] New extractor
[ ] New feature

Description of your pull request and other information

ability to almost have "|" "\" and "/" in filenames

sheerluck commented 4 years ago

Python-3 tests are ok, python-2 tests are broken. Who needs python-2 in 2020, right? :)

blackjack4494 commented 4 years ago

Well the python2 tests should still work. There is still support for Python2.
You may want to look at unichr here.
Also I am not quite sure what are the benefits of this? 😄

sheerluck commented 4 years ago

what are the benefits of this?

with my patch video https://www.youtube.com/watch?v=sZPC8TgLoNE will become FOB⧸MCR⧸Evanescence - Centuries⧸Welcome To The Black Parade⧸Bring Me To Life (Mashup).-sZPC8TgLoNE.webm

blackjack4494 commented 4 years ago

Is it really intended to have big slashes (big solidus)??

sheerluck commented 4 years ago

Big slashes look great. At least beats '_'