blackjackkent / RPThreadTrackerV3.FrontEnd

GNU General Public License v3.0
4 stars 5 forks source link

Fixing console warnings in unit tests #149

Closed blackjackkent closed 3 years ago

blackjackkent commented 3 years ago

Description

Fixing issues with prop types which were causing console warnings when running unit tests. (Also hoping to see if I can figure out why code coverage reports aren't working in pull requests anymore.)

Motivation and Context

Resolves #148

Types of changes

Checklist:

codecov[bot] commented 3 years ago

Codecov Report

Merging #149 (30b022e) into development (592e51e) will increase coverage by 99.15%. The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           development     #149       +/-   ##
================================================
+ Coverage             0   99.15%   +99.15%     
================================================
  Files                0      287      +287     
  Lines                0     3205     +3205     
  Branches             0      588      +588     
================================================
+ Hits                 0     3178     +3178     
- Misses               0       27       +27     
Impacted Files Coverage Δ
...y/forms/upsert-public-view/UpsertPublicViewForm.js 100.00% <ø> (ø)
src/display/shared/CharacterSelectItem.js 100.00% <ø> (ø)
src/display/shared/modals/UpsertCharacterModal.js 100.00% <ø> (ø)
src/display/shared/modals/UpsertThreadModal.js 100.00% <ø> (ø)
...rastructure/selectors/threads/getRecentActivity.js 100.00% <0.00%> (ø)
src/display/views/public/_columns.js 100.00% <0.00%> (ø)
...isplay/views/threads/components/_archiveColumns.js 100.00% <0.00%> (ø)
...rc/infrastructure/actions/threads/exportThreads.js 100.00% <0.00%> (ø)
src/infrastructure/withPageViewTracker.js 100.00% <0.00%> (ø)
...frastructure/actions/ui/bulkUntrackThreadsModal.js 100.00% <0.00%> (ø)
... and 281 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 592e51e...30b022e. Read the comment docs.