wharrrgarbl commented 3 years ago

Description

This was presumably broken by undocumented breaking changes in react-table from v6.8.6 -> v6.11.5

Motivation and Context

After selecting a thread row on the tracker, it cannot be deselected.

A current workaround is to use the "select all" checkbox, then uncheck that to reset state.

How Has This Been Tested?

Manual testing, unit tests updated

Screenshots (if appropriate):

This is where the new 'select-' prefix is coming from in react-table:

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #156 (fb4eca2) into development (4cba2bd) will not change coverage. The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           development      #156   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              285       285           
  Lines             3178      3178           
  Branches           584       584           
=============================================
  Hits              3178      3178

Impacted Files	Coverage Δ
.../display/views/threads/components/CheckboxTable.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cba2bd...fb4eca2. Read the comment docs.

blackjackkent commented 3 years ago

What an incredibly weird breaking change from the table lib. O.o Thanks for catching this - the fix looks good! 🚀

blackjackkent / RPThreadTrackerV3.FrontEnd

fix: row deselection for threads #156