Closed wharrrgarbl closed 3 years ago
Merging #158 (ec40cb4) into development (a7affeb) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## development #158 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 285 285
Lines 3178 3188 +10
Branches 584 586 +2
=============================================
+ Hits 3178 3188 +10
Impacted Files | Coverage Δ | |
---|---|---|
src/display/shared/columns/threads/LastPoster.js | 100.00% <100.00%> (ø) |
|
.../display/views/threads/components/CheckboxTable.js | 100.00% <100.00%> (ø) |
|
...rc/display/views/threads/components/_getTdProps.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a7affeb...ec40cb4. Read the comment docs.
Hey! Sorry for the delay in getting back to you on this; it looks good! Thanks for implementing it, and for checking on the further refactoring!
Unrelated, but just as a heads up, I am doing some major refactoring to the overall codebase; originally I was just going to experiment a bit with it but I picked up momentum and it's turning into a fairly significant rebuild that is definitely slimming down the codebase (removing Redux, introducing react-query
, and migrating to functional components with hooks across the board) and will also, I hope, reduce the annoying coverage prescriptiveness of the test suite. It shouldn't affect any of what you worked on here; it's mostly an infrastructural change, but I wanted to mention since you've been the main outside contributor thus far and might be interested. :) (And of course, if you want to be involved or have a look at the updated code, feel free to let me know.)
Description
Support clicking/tapping anywhere on a row to select it
Addresses item 3 in #135
Motivation and Context
No long requires clicking on the little checkbox to select a row
How Has This Been Tested?
Manual testing via local dev, unit tests added
Types of changes
Checklist: