nicm42 commented 3 years ago

Description

Updated navbar styles so sidebar appears in dark theme colours when dark theme is selected, and stays in light theme colours when light theme is selected.

Motivation and Context

Addresses item 5 in #135 People using dark mode will no longer be blinded by the sidebar

How Has This Been Tested?

I ran the navbar styles test. I did manual testing in dark and light mode.

Screenshots (if appropriate):

dark light

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #164 (98820f8) into development (a7affeb) will not change coverage. The diff coverage is 100.00%.

@@              Coverage Diff              @@
##           development      #164   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              285       285           
  Lines             3178      3188   +10     
  Branches           584       586    +2     
=============================================
+ Hits              3178      3188   +10

Impacted Files	Coverage Δ
.../display/views/help/components/AboutTrackerPane.js	`100.00% <ø> (ø)`
src/display/shared/columns/threads/LastPoster.js	`100.00% <100.00%> (ø)`
.../display/views/threads/components/CheckboxTable.js	`100.00% <100.00%> (ø)`
...rc/display/views/threads/components/_getTdProps.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7691747...98820f8. Read the comment docs.

blackjackkent commented 3 years ago

Hey! Thank you so much for this contribution! This looks great!

One thing - the border color on the right side of the sidebar in the dark theme now looks a little too bright. Can we maybe change that border to the GRAY_400 color constant, while keeping the light theme border GRAY_200?

Other than that, this is awesome; once that's changed, I can get it merged in. 🚀