blackjackkent / RPThreadTrackerV3.FrontEnd

GNU General Public License v3.0
4 stars 5 forks source link

Nav toggle on top of RP Thread Tracker title on large screens #165

Open nicm42 opened 3 years ago

nicm42 commented 3 years ago

Expected Behavior

On small screens, when the sidebar is hidden by default, the nav toggle is on the very left of the screen with the title to the right. This should be the same on larger screens, when the sidebar is showing by default.

This is how it should look (with nav toggle selected so it's clearer what's going on): expected

Current Behavior

On larger screens, when the sidebar is showing by default, the nav toggle is under the last R in the title.

This is how it looks (with nav toggle selected so it's clearer what's going on): current

Possible Solution

I don't know, I haven't looked.

Steps to Reproduce (for bugs)

  1. Make screen large enough that sidebar shows by default

Context

It's really not that important, given that I've been using it for ages and have only just noticed. The toggle still works, it's just not easy to see that it's there.

Your Environment

I have tried this in Linux in Firefox, Chrome and Vivaldi.

blackjackkent commented 3 years ago

Hm. This is a good usability note! I'm having some trouble reproducing it on my end, though - this is what the toggle looks like for me on my 2560x1440 monitor:

image

I wonder if this is somehow a Linux specific issue. 🤔 What size monitor and version of Linux/browsers are you using?

nicm42 commented 3 years ago

I'm also now thinking if it's a Linux (Mint) thing.

I've tried this on my work computer (Windows 1920x1080 Chrome 89) and it was fine.

I've tied changing the resolution on my computer to 1920x1080 and 2056x1440 and it was not fine. I'm currently using Linux Mint 20 Cinnamon, but I only recently changed to this - before that I was on Linux Mint 18.1 KDE and the problem was there too. I've tried this in Firefox 88, Chrome 90 and Vivaldi 3.7.2218.58. Vivaldi just updated today, yesterday it was on 3.7.2218.55.

I also tried it on Linux Mint 20 Cinnamon on a USB in Firefox 77. It was also a problem on there, so the problem is not any strange settings I've got on my computer.

blackjackkent commented 3 years ago

Interesting. 🤔 I have no idea how to replicate that in my current work environment, to be honest. I'd be all right with moving that toggle to the left side of the site name for all screen sizes, so if you'd like to do a PR for that and verify it looks all right in your environment as well, absolutely go for it! Otherwise I'll try to look at doing it myself at some point in the future.

nicm42 commented 3 years ago

I am up for doing that.

nicm42 commented 3 years ago

I've realised what the difference is between Windows and Linux: fonts. In windows, if you view the title in your dev tools, scroll down to the font-family definition and untick it, then you'll get the Linux problem.