search

blackjackshellac / kitchenTimer

Gnome shell kitchen timer extension
GNU General Public License v3.0
21 stars 10 forks source link

If possible, please support GNOME 3.36 #35

Closed eugene-rom closed 3 years ago

eugene-rom commented 3 years ago

While version 8 of this extension works in 3.36, version 10 is not.

It says in log: Jan 20 09:31:26 eugene gnome-shell[1214]: JS ERROR: Extension kitchentimer@blackjackshellac.ca: SyntaxError: invalid regexp group @ /home/eugene/.local/share/gnome-shell/extensions/kitchentimer@blackjackshellac.ca/alarm_timer.js:1

Settings dialog also not displayed.

I think, support for gnome 3.36 is good idea, as quite popular Ubuntu 20.04 LTS uses gnome 3.36. Thank you.

blackjackshellac commented 3 years ago

And I was so happy to finally see named capture groups in javascript. I'll look into it today.

eugene-rom commented 3 years ago

Thank you!

Correction for my post - v8 also doesn't work in 3.36, (Jan 20 13:57:46 eugene gjs[2135]: JS ERROR: Extension kitchentimer@blackjackshellac.ca: SyntaxError: invalid regexp group @ /home/eugene/.local/share/gnome-shell/extensions/kitchentimer@blackjackshellac.ca/menuitem.js:1).

v7 works ok.

blackjackshellac commented 3 years ago

Settings hsould work in 20.04 now

42369d15648b03ecd2033accc939af268b9a618e

blackjackshellac commented 3 years ago

Verified that the problem is named regex groups,

gjs> re=/(?<foo>[a-z]+)/;
typein:1:1 invalid regexp group:
typein:1:1 (?<foo>[a-z]+)
typein:1:1 .^
  @<stdin>:1:42
blackjackshellac commented 3 years ago

@eugene-rom can you try with the latest master branch from github?

eugene-rom commented 3 years ago

@blackjackshellac, tried, and it's fully working! Thank you!

blackjackshellac commented 3 years ago

Mostly working, I'll test a bit more and then submit an update to extensions.gnome.org. I'm going to close this now.