reubenharry commented 6 months ago

Thank you for opening a PR!

A few important guidelines and requirements before we can merge your PR:

[ ] If I add a new sampler, there is an issue discussing it already;
[ ] We should be able to understand what the PR does from its title only;
[ ] There is a high-level description of the changes;
[ ] There are links to all the relevant issues, discussions and PRs;
[ ] The branch is rebased on the latest main commit;
[ ] Commit messages follow these guidelines;
[ ] The code respects the current naming conventions;
[ ] Docstrings follow the numpy style guide
[ ] pre-commit is installed and configured on your machine, and you ran it before opening the PR;
[ ] There are tests covering the changes;
[ ] The doc is up-to-date;
[ ] *If I add a new sampler** I added/updated related examples

Consider opening a Draft PR if your work is still in progress but you would like some feedback from other contributors.

junpenglao commented 6 months ago

... is it your intention to merge into benchmark branch?

reubenharry commented 6 months ago

This is a draft, so isn't intended to be reviewed, and actually isn't intended to be merged.

junpenglao commented 6 months ago

Right but the benchmark branch is very outdated - let me fast forward it

junpenglao commented 6 months ago

Sorry i messed up update the branch... could you send the PR again?

blackjax-devs / blackjax