search

blackjax-devs / blackjax

BlackJAX is a Bayesian Inference library designed for ease of use, speed and modularity.
https://blackjax-devs.github.io/blackjax/
Apache License 2.0
806 stars 105 forks source link

Migrate progress bar from fastprogress to tqdm #655

Open zaxtax opened 6 months ago

zaxtax commented 6 months ago

Moves to use tqdm along with adding support for multiple progress bars

Makes blackjax suitable for running multiple chains in parallel.

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.80%. Comparing base (7cf4f9d) to head (b2d2273). Report is 1 commits behind head on main.

:exclamation: Current head b2d2273 differs from pull request most recent head bf703cd. Consider uploading reports for the commit bf703cd to get more accurate results

Files Patch % Lines
blackjax/progress_bar.py 91.30% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #655 +/- ## ========================================== - Coverage 98.87% 98.80% -0.07% ========================================== Files 59 59 Lines 2745 2752 +7 ========================================== + Hits 2714 2719 +5 - Misses 31 33 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

junpenglao commented 1 week ago

@zaxtax should we update this after https://github.com/blackjax-devs/blackjax/pull/712 and get it merge?

zaxtax commented 1 week ago

Do we still want to migrate to tqdm?

On Fri, 27 Sept 2024, 09:55 Junpeng Lao, @.***> wrote:

@zaxtax https://github.com/zaxtax should we update this after #712 https://github.com/blackjax-devs/blackjax/pull/712 and get it merge?

— Reply to this email directly, view it on GitHub https://github.com/blackjax-devs/blackjax/pull/655#issuecomment-2378644298, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACCUOYVZRJOXX7BDEYNFDZYUFNPAVCNFSM6AAAAABO6TKKOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYGY2DIMRZHA . You are receiving this because you were mentioned.Message ID: @.***>

junpenglao commented 1 week ago

I forgot the reason why we were doing this beside the pmap bug (which is now fixed)