Closed junpenglao closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.87%. Comparing base (
7cf4f9d
) to head (b1ca8a1
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Following new recommendation on RNG usage within a loop.
Main pattern: Instead of doing
do
The main concern here is that there is an unnecessary statistical inefficiency using the split-then-carry within a loop. By doing splitting, random number is generated by iterating the hash on keys at a fixed message, so the resulting sequence might have a shorter period than you expect.
Also change
jax.tree_map
tojax.tree.map