Remove option to give initial_position from run_inference_algorithm.
Description:
run_inference_algorithm currently uses a try-except clause to allow the user to either provide an initial position or an initial state. This has led to some problems, when the except clause fails to trigger.
More broadly, there doesn't seem to be a good reason to
Solution:
Make run_inference_algorithm only take initial_state, so that the caller of run_inference_algorithm is responsible for providing initial_state from initial_position, rather than deferring this task.
A few important guidelines and requirements before we can merge your PR:
[x] The branch is rebased on the latest main commit;
Remove option to give
initial_position
fromrun_inference_algorithm
.Description:
run_inference_algorithm
currently uses a try-except clause to allow the user to either provide an initial position or an initial state. This has led to some problems, when theexcept
clause fails to trigger.More broadly, there doesn't seem to be a good reason to
Solution:
Make
run_inference_algorithm
only takeinitial_state
, so that the caller ofrun_inference_algorithm
is responsible for providinginitial_state
frominitial_position
, rather than deferring this task.A few important guidelines and requirements before we can merge your PR:
main
commit;pre-commit
is installed and configured on your machine, and you ran it before opening the PR;