blackjax-devs / blackjax

BlackJAX is a Bayesian Inference library designed for ease of use, speed and modularity.
https://blackjax-devs.github.io/blackjax/
Apache License 2.0
806 stars 105 forks source link

New integrator, and add some metadata to integrators.py #681

Closed reubenharry closed 4 months ago

reubenharry commented 4 months ago

Addresses #679

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 46.00000% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 97.79%. Comparing base (7cf4f9d) to head (06dd04d). Report is 8 commits behind head on main.

:exclamation: Current head 06dd04d differs from pull request most recent head abe707c

Please upload reports for the commit abe707c to get more accurate results.

Files Patch % Lines
blackjax/mcmc/integrators.py 46.00% 27 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #681 +/- ## ========================================== - Coverage 98.87% 97.79% -1.09% ========================================== Files 59 59 Lines 2745 2806 +61 ========================================== + Hits 2714 2744 +30 - Misses 31 62 +31 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

reubenharry commented 4 months ago

I see that code coverage is complaining about integrator_order, name_integrator and calls_per_integrator_step. These seem useful, but depending on your view, I could remove them

junpenglao commented 4 months ago

I see that code coverage is complaining about integrator_order, name_integrator and calls_per_integrator_step. These seem useful, but depending on your view, I could remove them

Yeah please remove them, depending on what you want to check there should be better ways to return these properties.