search

blackknight467 / StarRatingBundle

star rating bundle for symfony
MIT License
26 stars 40 forks source link

add function resettable #13

Open marcelglaeser opened 7 years ago

blackknight467 commented 7 years ago

Hi @marcelglaeser

Thanks for the pull request. It looks like you're adding an icon at the end of the stars to reset the value back to 0, which is a good catch considering that was not an included feature before. Thanks.

My only comment for improvement in the readme is to include a picture of what reset looks like when enabled since it may not be immediately obvious. Thoughts?

marcelglaeser commented 7 years ago

You mean a picture like that? resettable

blackknight467 commented 7 years ago

exactly like that! Just include it under the

to enable resetable

and include a note about the resetable functionality and that it will reset the star value to 0.

marcelglaeser commented 7 years ago

Done. So okay? :)

marcelglaeser commented 7 years ago

I don't use the twig extension!

FloFrad commented 7 years ago

Is it possible to merge this PR please ?

marcelglaeser commented 5 years ago

Hi, can you merge this please?