blacklanternsecurity / baddns

Check subdomains for subdomain takeovers and other DNS tomfoolery
GNU General Public License v3.0
96 stars 5 forks source link

Silent mode naive implementation #479

Closed man3kin3ko closed 2 weeks ago

man3kin3ko commented 2 months ago

478 tried to implement it by myself. Please, check it out

liquidsec commented 1 month ago

Hey! Thanks for submitting this.

I am happy to pull it in, there are a couple little issues with it I can quickly fix... But I am wondering why you didn't want to full JSON output when there is a match? There is often lot more information than just target and signature.. and some vulnerable events don't even have signatures.

I think I'd prefer the output still be JSON, but otherwise I like this.

man3kin3ko commented 4 weeks ago

But I am wondering why you didn't want to full JSON output when there is a match? There is often lot more information than just target and signature.. and some vulnerable events don't even have signatures.

This is because I've put it into a long pipeline. I don't want to parse data or manually analyze it, so it's handy to get simple output and check false-positives later. Many such tools also implement this functionality, so I think it's not only me who find it useful.

some vulnerable events don't even have signatures.

I'm not sure how to deal with it, it was ad-hoc and naive implementation

liquidsec commented 2 weeks ago

closing this PR as this was added in https://github.com/blacklanternsecurity/baddns/pull/484