search

blacklight / nvim-http

An HTTP client for neovim inspired by vscode-restclient and the IntelliJ HTTP client
MIT License
87 stars 5 forks source link

Make HttpStop work #7

Closed oxcafedead closed 3 months ago

oxcafedead commented 7 months ago

Before, HttpStop handler was waiting till the main thread works, and the async task should be done first. Async task had that queue.get handler and process.join as well, so it was effectively blocking.

Remove those blocking operations so that we only spawn thread.

Probably, it also makes sense to remove vim async wrapper at all.

In the end, should fix #6

oxcafedead commented 7 months ago

Worked for me, and I hope I did not misunderstand something completely fundamental...

oxcafedead commented 7 months ago

The next step: figure out what to do with result queue :)

blacklight commented 3 months ago

Sorry for the delay, I completely missed the notifications from this project.

Approved and merged - thanks for the contribution!