search

blacklocus / metrics-cloudwatch

A reporter for codahale metrics to Amazon CloudWatch
Apache License 2.0
61 stars 27 forks source link

add support for reporter-wide global dimensions #12

Closed lukaszbudnik closed 8 years ago

lukaszbudnik commented 9 years ago

This pull request adds support for a reporter-wide global dimensions. Use case: in the cloud you may want to create instance-id, vpc-id, name tag dimensions and append them directly to the reporter.

Also, this is very useful if you want to integrate existing metrics (code hale JVM, Hikari, etc) and you don't have control over the names of the metrics.

cer commented 8 years ago

This PR implements a very useful feature. Thanks @lukaszbudnik What's the ETA on it being merged?

dirkraft commented 8 years ago

This looks pretty useful and should not interfere with users' existing integration. I'll merge it in with little fuss.

Thanks for your low review overhead contribution :smile: I will try to release a minor version with it tomorrow.

dirkraft commented 8 years ago

Hi,

Sonatype has accepted the new jar for

dependencies {
    compile 'com.blacklocus:metrics-cloudwatch:0.3.5'
}

It usually takes about a day for it to propagate out to maven central.