blackmagic-debug / blackmagic

In application debugger for ARM Cortex microcontrollers.
GNU General Public License v3.0
3.3k stars 775 forks source link

Fix: Add blackpill-f4 to meson CI #1975

Closed ALTracer closed 3 weeks ago

ALTracer commented 1 month ago

Detailed description

size-diff pass does not produce a downloadable artifact. scripts/meson-build-all.sh is unused.

I noticed you've got 5 flavours of native now, but I'm not adding them to build-PR.yml, because target driver code is checked on other adapter builds, and platform code can be checked once per platform.

Finally, I'm adding the four newly added/extracted and hence disabled groups of targets (apollo3.c; ch32,gd32,mm32 in stm32f1.c) to blackpill-f4 cross-files such that size-diff reflects their impact on binary size. Please confirm whether this needs to be expanded to all other big flash platforms.

Your checklist for this pull request

Closing issues

ALTracer commented 3 weeks ago

Rebased. Inaccuracy: the 5 flavours of native are NOT built per build-and-upload.yml triggered by pushes to main. But they are built for PR sync-pushes. Is this what you intended? I'm not touching those here, but sounds like users might expect native fw on main, too?

dragonmux commented 3 weeks ago

It is not what we intended and that is in fact another oversight on our part. If you wanted to include adding those flavours to build-and-upload before we merge, that would be most welcome.

ALTracer commented 3 weeks ago

Added 4 lines to the other CI matrix. Please check the commit message. Extends and/or fixes #1968, I think.