blackmann / compa

🌁 scoodent companion. Stay on top of tertiary school lifestyle with modern experiences.
https://compa.so
59 stars 18 forks source link

favicon in its own PR this time #16

Closed avi-l closed 7 months ago

avi-l commented 7 months ago

favicon update decoupled from my previous PR.

blackmann commented 7 months ago

@avi-l this PR is actually addressing wrong files.

You edited the favicon for website but placed the favicon inside client.

Please create a new PR, moving the favicon.ico into the website/public folder.

About the favicon for the client app, #15 is working on it… leave that for now

avi-l commented 7 months ago

@avi-l this PR is actually addressing wrong files.

You edited the favicon for website but placed the favicon inside client.

Please create a new PR, moving the favicon.ico into the website/public folder.

About the favicon for the client app, #15 is working on it… leave that for now

oh ok, my bad. i opened PR #18 .. there's a merge conflict though due to the other favicon thing. Sorry bout that.