search

blackmann / compa

🌁 scoodent companion. Stay on top of tertiary school lifestyle with modern experiences.
https://compa.so
59 stars 18 forks source link

moved favicon from client to website/public #20

Closed avi-l closed 7 months ago

avi-l commented 7 months ago

dev.db-journal was created when I started the app.

avi-l commented 7 months ago

dev.db-journal was created when I started the app.

removed via app

blackmann commented 7 months ago

Could you add the db journal to gitignore with this PR? So it saves us in future

avi-l commented 7 months ago

done. really .env should be in .gitignore also. if what you have in there is not sensitive then should just be in a consts export file or something like that

On Mon, Jan 29, 2024 at 11:41 AM Degreat @.***> wrote:

Could you add the db journal to gitignore with this PR? So it saves us in future

— Reply to this email directly, view it on GitHub https://github.com/blackmann/compa/pull/20#issuecomment-1914314122, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQHF5MKCIA2RENM4H4N3YCLYQ5VCZAVCNFSM6AAAAABCPBCMUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGMYTIMJSGI . You are receiving this because you authored the thread.Message ID: @.***>

avi-l commented 7 months ago

oh i just read the .env file comments, it's from prisma. but still.

On Mon, Jan 29, 2024 at 11:56 AM Avi Leeker @.***> wrote:

done. really .env should be in .gitignore also. if what you have in there is not sensitive then should just be in a consts export file or something like that

On Mon, Jan 29, 2024 at 11:41 AM Degreat @.***> wrote:

Could you add the db journal to gitignore with this PR? So it saves us in future

— Reply to this email directly, view it on GitHub https://github.com/blackmann/compa/pull/20#issuecomment-1914314122, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQHF5MKCIA2RENM4H4N3YCLYQ5VCZAVCNFSM6AAAAABCPBCMUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJUGMYTIMJSGI . You are receiving this because you authored the thread.Message ID: @.***>

blackmann commented 7 months ago

The .env is not used in prod. Remix doesn't use it (by default).

It's there for reference sake

No need to add to gitignore