Closed kwadwoatta closed 6 months ago
Also, we're sticking with yarn
pnpm helps to save on space and internet data. If my package download is interrupted and not successful, yarn will download everything again, pnpm will use what it has saved
See Yarn:cache
pnpm is still more efficient at saving space and faster than yarn
Okay... I'll look into it some time
@kwadwoatta is this still of interest?
@blackmann Yeah, I guess. I'm wondering why I'm getting these TS errors and API misuse and yours seems fine
@blackmann any changes you'd like me to make?
@kwadwoatta i see 170k changes. That's unusual. Should be a few 100s
@blackmann also did you try to run mine locally? any issues there?
@kwadwoatta I know for sure it's not going to work because of this: https://github.com/blackmann/compa/pull/60#discussion_r1537160436
I don't understand your opposition. It would seem I didn't have a good reason for doing what I did, though I treated every other import but this normally.
Which is why I asked if you ran the app.
You can do that and see for yourself:
RESEND_API_KEY=123 yarn dev:client
And also this PR will not be accepted if the changes are this huge. Please address that.
Yeah, you're right. The project runs fine though I'm seeing TS errors. Deleting ...
@blackmann kindly check client/app/routes/discussions.tsx and client/app/lib/render-summary.server.ts for ts type violations that need refactoring