blackmann / compa

🌁 scoodent companion. Stay on top of tertiary school lifestyle with modern experiences.
https://compa.so
58 stars 19 forks source link

make typescript compiler happy #60

Closed kwadwoatta closed 6 months ago

kwadwoatta commented 7 months ago

@blackmann kindly check client/app/routes/discussions.tsx and client/app/lib/render-summary.server.ts for ts type violations that need refactoring

blackmann commented 7 months ago

Also, we're sticking with yarn

kwadwoatta commented 7 months ago

pnpm helps to save on space and internet data. If my package download is interrupted and not successful, yarn will download everything again, pnpm will use what it has saved Screenshot 2024-03-25 at 9 21 02 AM

blackmann commented 7 months ago

See Yarn:cache

kwadwoatta commented 7 months ago

pnpm is still more efficient at saving space and faster than yarn

benchmark who's using pnpm who's using pnpm workspace

blackmann commented 7 months ago

Okay... I'll look into it some time

blackmann commented 6 months ago

@kwadwoatta is this still of interest?

kwadwoatta commented 6 months ago

@blackmann Yeah, I guess. I'm wondering why I'm getting these TS errors and API misuse and yours seems fine

kwadwoatta commented 6 months ago

@blackmann any changes you'd like me to make?

blackmann commented 6 months ago

@kwadwoatta i see 170k changes. That's unusual. Should be a few 100s

kwadwoatta commented 6 months ago

@blackmann also did you try to run mine locally? any issues there?

blackmann commented 6 months ago

@kwadwoatta I know for sure it's not going to work because of this: https://github.com/blackmann/compa/pull/60#discussion_r1537160436

I don't understand your opposition. It would seem I didn't have a good reason for doing what I did, though I treated every other import but this normally.

Which is why I asked if you ran the app.

You can do that and see for yourself:

RESEND_API_KEY=123 yarn dev:client

And also this PR will not be accepted if the changes are this huge. Please address that.

kwadwoatta commented 6 months ago

Yeah, you're right. The project runs fine though I'm seeing TS errors. Deleting ...

Screenshot 2024-04-05 at 8 35 56 AM Screenshot 2024-04-05 at 8 23 56 AM