blackmann / story_view

Story view for apps with stories.
BSD 3-Clause "New" or "Revised" License
417 stars 342 forks source link

Make Story View Directionality Aware (Support RTL) #179

Open FirasAlShawa opened 6 months ago

FirasAlShawa commented 6 months ago

Hi Team,

This PR to support RTL and LTR as default.

Kindly let me know if you need further information.

Thanks!

geekpius commented 4 months ago

I can see you wish to change the entire items to support RTL. Why do need this? What's the use case? If you could elaborate more on this.

FirasAlShawa commented 4 months ago

Hi @geekpius Currently Story View support LTR which make since for the english apps, but if the default language of the app is RTL(like Arabic) the stories will animate from left to right which is not correct.

So I add the directionality of the story progress bars and animation.

Please let me know if you need a screen record. Thank you!

FirasAlShawa commented 3 months ago

Hi @geekpius ,

Please any update regarding my PR?

Thank you!

geekpius commented 3 months ago

Hi @geekpius ,

Please any update regarding my PR?

Thank you!

I will go through and get back to you if I have questions. If not it will be merged