blackmennewstyle / miningcore

Miningcore is a high-performance Mining Pool Software for Linux and Windows.
MIT License
17 stars 34 forks source link

duplicate share from nicehash #112

Closed trampk closed 3 months ago

trampk commented 3 months ago

I began to notice that blocks were starting to be poorly caught on NiceHash and decided to check your pool and this is what I saw in the logs:

a1] Broadcasting job 0000005d [2024-03-25 16:31:37.9144] [I] [kaspa1] Detected new block 75061117 [BTS] [2024-03-25 16:31:37.9144] [I] [kaspa1] Broadcasting job 0000005e [2024-03-25 16:31:39.1916] [I] [kaspa1] [0HN2CT3NDC4MO] Share accepted: D=32768 [2024-03-25 16:31:39.2167] [I] [kaspa1] [0HN2CT3NDC4NA] Share rejected: duplicate share [NiceHash/1.0.0] [2024-03-25 16:31:39.2339] [I] [kaspa1] Detected new block 75061118 [BTS] [2024-03-25 16:31:39.2339] [I] [kaspa1] Broadcasting job 0000005f [2024-03-25 16:31:39.2808] [I] [kaspa1] [0HN2CT3NDC4MU] Share rejected: duplicate share [NiceHash/1.0.0] [2024-03-25 16:31:39.3006] [I] [kaspa1] [0HN2CT3NDC4M2] Share rejected: duplicate share [NiceHash/1.0.0]

I checked with mine Iceriver KS2 and diff 4096 - all ok in kaspabridge also doesn't show duplicates

Do you think it’s Nicehash sending duplicates or Minincore bug? extranonce =10, diff 32768

UPD - Looks like the problem was an incorrectly set value extranonce