Open blackmirag3 opened 4 months ago
The Currency Converter feature was intended to be executed within the CLI program and not by manually editing the data file. The UG has already warned that editing the file may lead to the application behaving unexpectedly.
However, as the program still functions as per normal and the bug only occurs when going against the instructions, I believe it should be classified as "Low".
Team chose [response.NotInScope
]
Reason for disagreement: Manually editing text files (including default currency) is a feature declared in the UG in chapter 6.2. The feature is clearly intended to be within the V2.1 scope
--
From course website:
response.NotInScope: It is a valid issue but not something the team should be penalized for e.g., it was not related to features delivered in v2.1 or lower priority than the work already done in v2.1.
If user edits the currency manually via file editing, the UG or DG does not warn user that pre-existing data that is loaded the next time programme is run will not be converted to new currency.
Info from Ug/DG![Screenshot 2024-04-19 at 5.38.18 PM.png](https://raw.githubusercontent.com/blackmirag3/pe/main/files/846e6f10-3778-48f9-ac0b-3ca7cd5a9537.png)
Here, I manually edited currency to SGD from HKD and it preexisting expenses do not change![Screenshot 2024-04-19 at 5.39.26 PM.png](https://raw.githubusercontent.com/blackmirag3/pe/main/files/c2e66114-78a1-474b-a65e-244d90c28973.png)