blackonyyx / pe

0 stars 0 forks source link

Edit Feature is hard to, if not almost impossible to test properly due to online functionalities. #3

Open blackonyyx opened 3 years ago

blackonyyx commented 3 years ago

As mentioned previously, the application requires an online querying to validate that a given module does not exist. Hence this fails as a feature I cannot add an new module that perhaps is a DYOM module not stored on NUSMODS, and is not a feature I can reasonably test. Similarly, what if I have done a module on exchange, and want to add it to my completed list?

Suggestion is to store a portion of Modules offline, or have a mode that is offline, such that features can be tested more reasonably, and allow new module codes to be created. Screenshot 2020-11-13 at 4.42.13 PM.png

Screenshot 2020-11-13 at 4.38.14 PM.png

nus-se-bot commented 3 years ago

Team's Response

As stated in our UG, edit command works offline and can still be tested on modules in the CS curriculum.

image.png

As for the coverage of DYOM modules, as our current database of modules extends to only NUSMODS and the School of Computing Website, it is impossible to have coverage of DYOM modules on our part.

As for DYOM modules, they do not affect the majority of our target audience, since only a small portion of CS students embark on this, hence it cannot be classified as a high severity issue.

As for exchange modules, every module has to be mapped back to a module within NUS. Furthermore, users would be aware of what these mappings are when applying for exchange, hence there is no need to account for the various overseas universities module codes. It is also out of our reach to gain access to every university's module database.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Due to the always online format of the application GradPad, the application's offline functionability is not testable in the given testing environment, the claimed offline functionality can therefore not be reproduced and is thus a flaw of the application in general (due to the main set functionality being based on the online connection). Similarly, under the given exam conditions, I cannot disconnect my internet connection, much like an "audio-related feature". Since this causes the project to fail the constraints of the project, that is to be testable under exam conditions, it is not reasonable to accept their refutation of this limitation.

Screenshot 2020-11-18 at 5.27.59 PM.png


:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: Firstly, as the issue regarding testibility of their product affects all their listed features of GradPad, and is not restricted to the edit command, it deserves a High Severity.

In terms of DYOM/ Exchange Students I dispute this, as it is not true that it would only affect a small section of students, almost 25% of CS students go overseas for exchange on NOC or SEP(pre covid) , furthermore it is not always so, that there exists a equivalent module in NUSMODs to map to. As such, since there is a sizable margin of people who may be affected, it deserves the severity given, cumulating with the above issue of testibility.