blackonyyx / pe

0 stars 0 forks source link

Required feature requires connectivity to internet #4

Open blackonyyx opened 3 years ago

blackonyyx commented 3 years ago

Acceptance Test bug: The feature does not pass the requirement to help CS students plan for graduation, as there is no check for qualifying for specialisation tracks. Hence it does not fully meet the requirements for managing the requriements for a CS undergraduate as mentioned in the User Guide.

Screenshot 2020-11-13 at 4.55.02 PM.png Requirements checking: Screenshot 2020-11-13 at 4.54.11 PM.png

Furthermore, many of the validation steps for preclusions, are likely a part of the NUSMODS Database api functionality.

nus-se-bot commented 3 years ago

Team's Response

Preface: the issue is unclear, but we identified 3 bugs within and have addressed them as such:

Required feature requires internet connectivity to function: (Rejected) Required feature works offline, as the required modules are stored as JSON files and not dependent on NUSMODS and internet connectivity. (Assignees: yan-soon)

Specialisation tracks: (Accepted, Low) We have decided to exclude this feature for this implementation of the project due to the time constraint, however it is a feature that we considered for future iterations. Furthermore, the app still allows you to search for and add specialisation modules (just that they are not tracked under required), thus it does not entirely blindside the specialisation track. (Assignees: everyone)

Preclusion: (Rejected) Our preclusion data is once again stored as JSON files, and is not dependent on NUSMODS and internet connectivity. (Assignees: yan-soon)

Items for the Tester to Verify

:question: Issue response

Team chose [response.IssueUnclear]

Reason for disagreement: The issue is clearly a feature flaw with the Specialisation Track. Due to exam conditions, I forgot to update the title oops. :O

I dispute that it is a Low Severity issue, as this is an app to track graduation requirements and graduation planning.

As such it must address the specialisation tracks problems as this is by definition a required and in-scope functionality requirement of the specialisation modules.

Searching for them necessitates that I already know the Module Code, which I may not know when planning using this "all-in-one" application, considering that there is no suggested results from using find command either. Therefore I cannot find what modules would qualify for a specialisation anyway and therefore cannot use this prescribed way to check specialisation of modules.

Screenshot 2020-11-19 at 12.33.00 AM.png