search

blackonyyx / pe

0 stars 0 forks source link

Sequence diagram loop condition phrasing #9

Open blackonyyx opened 3 years ago

blackonyyx commented 3 years ago

Loop condition used is not phrased in plain english, this is not pythonic code.

Consider using: while new summaries exist. Screenshot 2020-11-13 at 5.24.43 PM.png

image.png

nus-se-bot commented 3 years ago

Team's Response

Rejected as we think that it is quite clear what the loop condition means. In full english, this would be "for each summary in summaries, execute the loop body", which is not too far off from "for summary in summaries" as a condition for the loop.

Additionally, the target audience for the DG are developers, which are assumed to be coders.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]