search

blackpanther9229 / pe

0 stars 0 forks source link

Unhandle case of `find` command #3

Open blackpanther9229 opened 1 week ago

blackpanther9229 commented 1 week ago

Step to reproduce execute find t/ Expected list of every contacts, because the tag I am looking for is null Actual list of only contacts that has a least 1 tag

image.png

Severity I believe this is rather a documentation bug, which should be included in UG

soc-se-bot commented 4 days ago

Team's Response

The ability to do a blank search (eg. t/) is a byproduct of the PR enabling the deletion of optional fields through edit. Doing searches with no parameters is not very useful. Searching t/ will bring up any person who has any tag (as the description field is blank). This behavior is as expected for v1.6. I can understand the confusion caused to the bug reporter.

However, since the program is able to smoothly handle the situation it is not a high priority. A person using t/ to search for all contacts is not a useful feature. Since doing blank searches isn't useful and it was introduced by accident it should be removed in the future, but there were more pressing issues so this was delayed. Hence, this will be handled in the future and is out of the scope of v1.6.

Note this isn't a documentation bug because the feature itself is flawed and would ideally not allow blank searches, but again this was out of the scope of the current implementation.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I disagree. Although the program can handle it smoothly, this is still an unexpected behaviour, which has to be clearified in the UG, User Case, or at least in Planned Enhancement section . Non of this 3 mentioned this behaviour, that is why I set the bug to be documentation bug.

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [x] I disagree **Reason for disagreement:** As explained above.