blackrock / ingen

InGen is a command line tool written on top of pandas and great_expectations to perform small scale data transformations and validations without writing code.
Apache License 2.0
14 stars 5 forks source link

[REFACTOR] formatter and json_util to use more pythonic coding style #17

Closed swarnadhakad closed 1 year ago

swarnadhakad commented 1 year ago

Description

Issue

Changes Made

Utils to use more pythonic for loop Formatters to use columns.get instead of columns[] Add a method to add new formatters refactor json_utils

Definition of Done

Before submitting this pull request, please ensure that the following criteria have been met:

Additional Notes

[Add any additional notes or context for the reviewer or future maintainers of this code.]

Thank you for submitting!

PoojaKatariya1811 commented 1 year ago

Hi @swarnadhakad. Can we run the functionality once end to end and attach some testing snapshot? Just to ensure all of these changes are working as expected.

swarnadhakad commented 1 year ago

Hi @swarnadhakad. Can we run the functionality once end to end and attach some testing snapshot? Just to ensure all of these changes are working as expected.

@PoojaKatariya1811 Since all these changes are very syntactical in nature and have been tested using test cases, I would like to go ahead and merge this change.