blackrock / protoc-jar-maven-plugin

Maven plugin to compile protobuf proto files into java source code
Apache License 2.0
9 stars 3 forks source link

Feature/fix plugin versions in protoc jar module #4

Closed spensonshih closed 9 months ago

spensonshih commented 9 months ago

Fixes all build issues.

Description

[Describe the issue or feature that this pull request is addressing. Provide context and any relevant links to issues or documentation.]

Changes Made

  1. Renamed the maven-plugin module to protoc-maven-plugin. It was warning that maven-___-plugin pattern was reserved for plugins in org.apache.maven.plugins group.
  2. Updated versions to 1.0.0-SNAPSHOT
  3. Defined the versions of maven-javadoc-plugin and maven-plugin-plugin to the same version used in os72 code and using maven 3.8.x. Newer versions have incompatiibilty due to the way the plugin mojo is defined. We can upgrade these plugins once we fix the Mojo to use the new way of using Java annotations.
  4. Disabled the MojoShadingTest - I think we don't want the shading output type. Todo need to update the code to remove this support.
  5. Refactor the plugin artifactId in the pom.xml of the integration tests (test/jprojects/*/pom.xml) to reflect the new artifactId.

Definition of Done

Before submitting this pull request, please ensure that the following criteria have been met: