blacksky-algorithms / rsky

An AT Protocol Implementation built in Rust.
https://blackskyweb.xyz
Apache License 2.0
62 stars 4 forks source link

Standardize on libipld::Cid where possible #9

Closed rudyfraser closed 1 month ago

rudyfraser commented 3 months ago

Libipld is the Rust library for IPLD (https://github.com/ipld/libipld) which includes support for IPLD objects and is used in conjunction with serde_ipld_dagcbor.

Newer crates in the rsky repo use libipld::Cid but the first two (rsky-firehose and rsky-feedgen) use the cid crate. There are some slight differences between the two and I think it would be best to standardize on one, preferably the libipld one.

I don't think rsky-feedgen even uses cid even though it's listed as a dependency (can probably just be removed). The firehose crate will need its car.rs module updated.