search

blacksmithgu / obsidian-dataview

A data index and query language over Markdown files, for https://obsidian.md/.
https://blacksmithgu.github.io/obsidian-dataview/
MIT License
7.05k stars 414 forks source link

Recurring tasks do not recur if checked from dataview TASK query #1598

Open danrfletcher opened 1 year ago

danrfletcher commented 1 year ago

What happened?

I would like to report this bug relating to the cross-utilisation of Dataview with Obsidian tasks.

Contextual Info

Dataview supports basic task notation for start date, due date, completion date etc following the syntax outlined in Obsidian Tasks. Dataview provides some additional functionality for task queries. Would like to switch from basic task queries using Obsidian Tasks, to more advanced queries in Dataview.

Steps to Recreate

Install Obsidian Tasks & Dataview Create a recurring task using 🔁 emoji with specified interval. Create a dataview query that fetches this task. Check off the task from the dataview query. Note that the task will not recur.

DQL

TASK 
WHERE !completed AND contains(file.folder, this.file.folder)
GROUP BY file.link

JS

No response

Dataview Version

0.5.47

Obsidian Version

1.0.3

OS

Windows

claremacrae commented 1 year ago

Hi @blacksmithgu,

I guess this is not really a bug, it's a feature report to add support for recurring tasks to dataview. I asked the author to kindly create this request, after it was first (understandably) reported as a Tasks bug, and I am grateful that they have done so.

I'm the maintainer of the Tasks plugin, and I know how tricky it is to handle the many corner cases of recurring tasks.

Behind the scenes I have been looking for developers of plugins that handle task completion, to offer to make the recurrence/repeat code in the Tasks plugin available to their plugins.

Either by creating an npm module or exposing a method on the tasks plugin itself.

I favour the former, as it doesn't depend on users having the Tasks plugin installed.

I have a pretty good idea of the steps involved - but don't have the time to get to know the changes required in every other plugin.

So... if you, or someone in your team, would like to pair-program with me to jointly implement this, I would be delighted to help out.

There is an email address in my GitHub profile, to set up the first pairing session.

AB1908 commented 1 year ago

Hello Clare! blacksmithgu was actually hoping to defer to the Tasks plugin instead. See comment here: https://github.com/blacksmithgu/obsidian-dataview/issues/1534#issuecomment-1298092327. I'm personally in favor of deferring to your plugin as well since it seems like a duplication of effort. Curious what blacksmithgu has to say about this.

claremacrae commented 1 year ago

Hello Clare! blacksmithgu was actually hoping to defer to the Tasks plugin instead. See comment here: #1534 (comment). I'm personally in favor of deferring to your plugin as well since it seems like a duplication of effort. Curious what blacksmithgu has to say about this.

Hello AB!

That works for me too.... Same offer applies @blacksmithgu. If someone who knows the dataview code well enough wants to commit to several pairing sessions to work on this together I would be very happy to do so.

Also, I was considering binning Tasks' file reading code and using the dataview API instead - so there's a lot of potential gain here.

blacksmithgu commented 1 year ago

I am currently looking into separating the Dataview index into a generic API independent of the plugin itself - this would allow for it to be embedded and shared in both plug-ins. I'm fine with scheduling some time to chat and improve the task index enough to be Ysabel by both plug-ins.