blacktwin / JBOPS

Just a Bunch Of Plex Scripts
1.67k stars 307 forks source link

Update hide_episode_spoilers to change all shows. #315

Closed aldo-o closed 2 years ago

aldo-o commented 2 years ago

--rating_key is optional now. If it's not defined, the script will update all shows.

blacktwin commented 2 years ago

If it's not defined, the script will update all shows.

You don't see a problem with that?

aldo-o commented 2 years ago

You don't see a problem with that?

I'm sorry. I did not understand your reply. Where might be the problem?

blacktwin commented 2 years ago

Sorry for the hot response with no immediate follow up. The issue I see is that the simple mistake of not using the --rating_key arg would have a very big impact on someone's server. I don't think something so simple as missing an arg should trigger such a large change to an environment. I can see utilizing this edit or a form of it for a 1 time run then lean on Tautulli to slip the poster back. However the intend of this script is to be used with Tautulli and have Tautulli manage what is hidden and then what is revealed.

I don't want to include a change that would allow for such a big change in someone's server.

blacktwin commented 2 years ago

Please see the example in #317