blackuy / react-native-twilio-video-webrtc

Twilio Video (WebRTC) for React Native
https://www.twilio.com/docs/video
MIT License
609 stars 403 forks source link

Question: Is this a safe way to handle `scaleType` | scaleType does not update the view #386

Open marqroldan opened 4 years ago

marqroldan commented 4 years ago

Steps to reproduce

Expected behaviour

Actual behaviour

Environment

react-native-twilio-video-webrtc

Version: master


I can update it if I update the key (currently doing ${trackSid}_${this.state.scaleType}) However, does it have any negative impact? Right now I don't think there is, but I'm opening the issue just in case

slycoder commented 3 years ago

Yeah, looks like the code is not properly checking and updating the view when the prop changes.