search

blackuy / react-native-twilio-video-webrtc

Twilio Video (WebRTC) for React Native
https://www.twilio.com/docs/video
MIT License
607 stars 402 forks source link

I can here my self during call and also how can i manage speaker toggle on and off using this library? #510

Open krupalikevadiya opened 3 years ago

krupalikevadiya commented 3 years ago

I can here my self during call and also how can we manage ON and OFF status of speaker using this library? I'm using "react-native-twilio-video-webrtc": "https://github.com/blackuy/react-native-twilio-video-webrtc" in my app. twillio_video.toggleSoundSetup does not work in ios. Is there any configuration or anything else to overcome this issue?

slycoder commented 3 years ago

To your first point, does this mean echo cancelation is not working? It would help to know a little more about the device in question to dive deeper there.

There are some other issues with respect to toggling output device (ie #511). I'll follow up there.

krupalikevadiya commented 3 years ago

I'm canceling echo through this.twillio_video.disableOpenSLES() and it is working but when i'm on call i can here my self after i stop to speak. Detail of devices are : 1.Pixel 3 with android 11 2.iphone xs

slycoder commented 3 years ago

Based on your description, it kind of sounds like the echo is coming back from the other party (i.e. if they mute do you still hear the echo)? Is the second party also using echo cancellation?

n.b. disableOpenSLES is only applicable to a few Android devices; I would avoid using it and instead relying on the default echo cancellation.

krupalikevadiya commented 3 years ago

Yes second party also use echo cancellation and i don't have issue with echo but main issue is i speak something on call i can hear exact what i speak after i stop means i can hear my self after i stop to speak.

slycoder commented 3 years ago

Yeah, I understand you there; I'm just trying to see if what you're hearing is your voice going through the second party, coming back through their mic and being played back to you (as opposed to a purely local loopback).

krupalikevadiya commented 3 years ago

yaa happens something like that what you say...can you please give me some solution for it?

slycoder commented 3 years ago

So as I said earlier, it sounds like their echo cancellation may not be working correctly. Do you have more info on the settings they are using? If they mute or use headphones, does that improve the issue?

krupalikevadiya commented 3 years ago

yes they use headphone and meeting is ongoing in Microsoft Team while testing..we are also tested by mute ourself in team but still can here ourself in call.

krupalikevadiya commented 3 years ago

@slycoder any updtae on it?

yoramboccia-IR commented 2 years ago

Any update on fixing echo cancellation?

nicolasdevienne commented 2 years ago

I'm canceling echo through this.twillio_video.disableOpenSLES() and it is working but when i'm on call i can here my self after i stop to speak. Detail of devices are : 1.Pixel 3 with android 11 2.iphone xs

Same issue for me. When I'm on call I can here myself. Device : Pixel 2