search

blackuy / react-native-twilio-video-webrtc

Twilio Video (WebRTC) for React Native
https://www.twilio.com/docs/video
MIT License
608 stars 404 forks source link

[android] Remove stream voice control and only add them when they're connected #558

Closed marqroldan closed 3 years ago

marqroldan commented 3 years ago

Right now on Android, once the RNCustomTwilioVideoView native component is instantiated, the voice call stream is automatically selected for volume control even if you're not in a room

This PR makes it so that it only happens when you have successfully connected to a room, and reverts back to the default volume control stream when you are not connected

The images below are after the code has been updated

Sorry for the noise in the diff, I formatted the file using Android Studio's CTRL+ALT+L (for windows), please let me know if you want them cleaned

slycoder commented 3 years ago

Thanks for the contribution @marqroldan ! All of these improvements are really shoring up the android stack!