search

blackuy / react-native-twilio-video-webrtc

Twilio Video (WebRTC) for React Native
https://www.twilio.com/docs/video
MIT License
608 stars 403 forks source link

Android X support #630

Open munjo5746 opened 2 years ago

munjo5746 commented 2 years ago

Steps to reproduce

  1. Setup react-native-twilio-video-webrtc on expo project with custom plugins.
  2. Run EAS build for android.

Expected behaviour

The android app built on EAS.

Actual behaviour

Build fails with error message, symbol: class NonNull

Environment

react-native-twilio-video-webrtc

Version: npm version or "master"

munjo5746 commented 2 years ago

Will there be any chance this PR gets merged??

slycoder commented 2 years ago

There are some changes requested on that PR. If you have the bandwidth to update it with the requested changes, I'd be happy to merge!

munjo5746 commented 2 years ago

There are some changes requested on that PR. If you have the bandwidth to update it with the requested changes, I'd be happy to merge!

I have added PR with requested changes, PR. Please let me know if there are additional changes required. @slycoder