Screen sharing not working - Githubissues

blackuy / react-native-twilio-video-webrtc

Twilio Video (WebRTC) for React Native

https://www.twilio.com/docs/video

MIT License

606 stars 403 forks source link

Screen sharing not working #737

Open poojalivin opened 8 months ago

poojalivin commented 8 months ago

Steps to reproduce

I have used this reference for installation https://github.com/blackuy/react-native-twilio-video-webrtc .It was successful and I was able to implement the features too. But I couldn't find any method "setScreenShareEnabled" in my TwilioVideo.android.js file which is in node_modules/react-native-twilio-video-webrtc/src.
I tried to implement that method manually. Like added

"onScreenShareChanged: PropTypes.func" in "propTypes"
"toggleScreenShare: 16" in nativeEvents
added method,

setScreenShareEnabled (enabled) { this.runCommand(nativeEvents.toggleScreenShare, [enabled]) }
"onScreenShareChanged" in buildNativeEventWrappers()

But the event onScreenShareChanged was not triggered on setting setScreenShareEnabled(true).

Environment

Node.js version:
React Native version: ^0.64.4
**buildToolsVersion = "29.0.2" minSdkVersion = 21 compileSdkVersion = 29 targetSdkVersion = 29

react-native-twilio-video-webrtc

Version: "react-native-twilio-video-webrtc": "github:blackuy/react-native-twilio-video-webrtc" npm: '8.11.0',

gastonmorixe commented 15 hours ago

Thanks for sharing. We'll add it to the pipeline and have updates soon.