search

blackwinter / ruby-filemagic

Ruby bindings to the magic(4) library, revised.
https://blackwinter.github.iom/ruby-filemagic
146 stars 34 forks source link

Fix no function exception if no 'magic_getpath' function #17

Closed majioa closed 9 years ago

majioa commented 9 years ago

In version of the libmagic1.0.0 the 'magic_getpath' function is absent. So the code require 'filemagic' throws the exception of no function. The patch just fixes the problem defaulting the call to FileMagic.path to nil.

blackwinter commented 9 years ago

Do you really think supporting such an old version is worth the trouble? magic_getpath was introduced in libmagic 5.04 which dates back to January 2010. Even Debian Squeeze (currently oldoldstable) contains it. Which platform are you on that you have this antiquated version and can't update?

majioa commented 9 years ago

@blackwinter all novel versions (including Sisyphus) of Altlinux have the older than 2010 year version of file. For no I have added the some constats of TOT of file project.

blackwinter commented 9 years ago

I'm sorry Malo, I'm not convinced that support for anything prior to 5.11 is warranted. Please use ruby-filemagic < 0.6.0 if you can't update libmagic.

As an aside: Please don't mix unrelated changes in a pull request. If you open a new pull request for the new magic constants, I'll gladly merge it.

majioa commented 9 years ago

@blackwinter Restrision to support version 5.11 that isn't good approach to support/develop of open source applications... I just sorry that I generated the patch and got into communication with you.

blackwinter commented 9 years ago

Well, I'm sorry you feel that way. But I don't think it's fair to criticize the way I'm handling this project. It's clearly in maintenance mode, only issue reports are addressed at the moment. This also means that I don't take on responsibility for past upstream versions, only newer changes will be reflected. And I explicitly encouraged you to contribute the new libmagic constants.

As for the failed communication and your efforts being in vain: I've included the above points in the contribution guidelines.