search

blade-ui-kit / blade-heroicons

A package to easily make use of Heroicons in your Laravel Blade views.
https://blade-ui-kit.com/blade-icons
MIT License
551 stars 50 forks source link

Fix fill for o-academic-cap.svg #12

Closed Jubeki closed 3 years ago

Jubeki commented 3 years ago

This fixes the background fill of the svg. Currently, it renders with a white background.

driesvints commented 3 years ago

Heya thanks for submitting this. This has been submitted before but I see the original Heroicons still have this fill: https://github.com/tailwindlabs/heroicons/blob/master/optimized/outline/academic-cap.svg?short_path=c23120b#L2

I think it's best that this is fixed in Heroicons first before we change anything here. I usually just sync everything with the optimized Heroicons so this would be reverted the next time I do that. I see there's a PR open for this on the Heroicons repo so let's give that one an upvote: https://github.com/tailwindlabs/heroicons/pull/149