search

blade-ui-kit / blade-heroicons

A package to easily make use of Heroicons in your Laravel Blade views.
https://blade-ui-kit.com/blade-icons
MIT License
560 stars 50 forks source link

Update heroicons v2 #28

Closed duongtdvn closed 2 years ago

duongtdvn commented 2 years ago

I have added/updated all new icons from the optimized directory without the mini (20px) set.

Jubeki commented 2 years ago

Maybe the prefix sm- can be used for the small icon set?

duongtdvn commented 2 years ago

I was thinking about ms- which stands for mini solid since there is only a solid set by now, but maybe someday they will release the outline set so in which case we can use the mo-. However, sm- and om- are also good choices.

driesvints commented 2 years ago

I added the mini icons with the m- prefix. As long as there's no outline version of them there's nothing to worry about I think.

driesvints commented 2 years ago

Thanks!

risangbaskoro commented 2 years ago

As long as there's no outline version of them there's nothing to worry about I think.

In Heroicons' repo, icons are separated by sizes and solid/outline type. I agree with @duongtdvn's and @Jubeki's suggestions about adding a solid/outline prefix, since there's still a probability that they will release an outlined version, sooner or later.

Will it be more work if devs need to replace m- prefix to adjust for future release?

Jubeki commented 2 years ago

So just to clarify I meant sm as in small and not as solid mini but I can see that that is a little confusing in the context.

I am completely fine with only the m Prefix (2.0.0 of blade-heroicons is already released, so that would be a little late for changing that)

I also don't think that there will be another set type (small outline) for heroicons soon.

driesvints commented 2 years ago

If there's another set we can name it m-o- or something