search

blade-ui-kit / blade-icons

A package to easily make use of SVG icons in your Laravel Blade views.
https://blade-ui-kit.com/blade-icons
MIT License
2.21k stars 148 forks source link

Laravel 11 #223

Closed robsontenorio closed 9 months ago

robsontenorio commented 10 months ago
driesvints commented 10 months ago

Heya. Can you also add the new test bench version and update the matrix build on the GHA?

robsontenorio commented 10 months ago

Done! But it fails because v11 dependencies :(

driesvints commented 10 months ago

What's weird is that the exact same build on Ubuntu does work. I'm gonna leave this open until after Laravel v11's release and then merge and tag.

driesvints commented 9 months ago

Is disabled the Laravel v11 windows build for now. Thanks!

owenvoke commented 9 months ago

This might be happening because Windows treats ^ as an escape character. 🤔 If this is the issue, an alternative is to change to "illuminate/contracts=${{ matrix.laravel }}.*" 🙂 I would have thought it'd have been fine though, as it's quoted, but perhaps not.

driesvints commented 9 months ago

@owenvoke seems that worked! https://github.com/blade-ui-kit/blade-icons/pull/224

Thanks :)