search

blaenk / wp-recaptcha

I gave ownership of this project to Google many years ago
Other
38 stars 16 forks source link

Make sure no WP_DEBUG notices are generated by wp-recaptcha #32

Open jerclarke opened 13 years ago

jerclarke commented 13 years ago

Hey man, it's possible that the new version will already have this solved because you rewrote it, but the current/old version causes notices to be shown when WP_DEBUG is enabled.

WP_DEBUG is not the most popular feature in WP but it is a very useful and important one that many plugin and core developers use when developing because it activates the display of many errors that help you write safer and cleaner PHP.

http://codex.wordpress.org/Editing_wp-config.php#Debug

The old version of wp-recaptcha uses the deprecated third argument in add_option() when registering them, and this triggers errors on screen that force me to disable your plugin while working on my dev sites where WP_DEBUG is enabled.

I will just remove the third argument from my copy of the old version for now, but if you can, please enable WP_DEBUG while you are working on the plugin to try and ensure that no notices are generated by it. It will also help you avoid a ton of other little problems with your code.

Thanks for working so hard on the plugin, looking forward to the new version.

blaenk commented 13 years ago

Hey Jeremy, thanks for the heads up and the information too!