search

blai / grunt-express

Start an Express.js web server using grunt.js
MIT License
254 stars 41 forks source link

Change to work with Express 4. Pipeline stack moved from application ob... #65

Closed dhaub closed 10 years ago

dhaub commented 10 years ago

...object to the application._route object

Issue #64

Sorry no tests. Couldn't get the test suite to run. The following error occurred: Fatal error: Cannot find module 'grunt-contrib-watch/test/tasks/helper'

blai commented 10 years ago

Thanks.

aktary commented 10 years ago

I just tried the updated util.js in my 1.3.5 install and it failed spectacularly. This probably shouldn't be merged into main yet...

dhaub commented 10 years ago

I'm using 1.4.0. Try that version.

On Thu, Jul 3, 2014 at 4:45 PM, aktary notifications@github.com wrote:

I just tried the updated util.js in my 1.3.5 install and it failed spectacularly. This probably shouldn't be merged into main yet...

— Reply to this email directly or view it on GitHub https://github.com/blai/grunt-express/pull/65#issuecomment-47982761.

aktary commented 10 years ago

How? 1.4.0 doesn't compile!

https://travis-ci.org/blai/grunt-express

On Sat, Jul 5, 2014 at 11:13 AM, dhaub notifications@github.com wrote:

I'm using 1.4.0. Try that version.

On Thu, Jul 3, 2014 at 4:45 PM, aktary notifications@github.com wrote:

I just tried the updated util.js in my 1.3.5 install and it failed spectacularly. This probably shouldn't be merged into main yet...

— Reply to this email directly or view it on GitHub https://github.com/blai/grunt-express/pull/65#issuecomment-47982761.

— Reply to this email directly or view it on GitHub https://github.com/blai/grunt-express/pull/65#issuecomment-48092816.

blai commented 10 years ago

I think the test is failing on both 1.3.5 an 1.4.0. I do not have time to fix that yet, but you should be able to use 1.4.0 with Express 4

aktary commented 10 years ago

yep... looks like 1.4.0 worked. Not sure why it failed when I manually updated the 1.3.5 util.js code unless there were other changes made in the codebase somewhere.... anyway... thanks.

On Mon, Jul 7, 2014 at 2:03 PM, Brian Lai notifications@github.com wrote:

I think the test is failing on both 1.3.5 an 1.4.0. I do not have time to fix that yet, but you should be able to use 1.4.0 with Express 4

— Reply to this email directly or view it on GitHub https://github.com/blai/grunt-express/pull/65#issuecomment-48240654.