blaiprat / jquery.animateSprite

Animating sprites using jQuery made easy
http://blaiprat.github.io/jquery.animateSprite/
MIT License
122 stars 39 forks source link

Stop not working #14

Open mumbaimerijaan opened 6 years ago

mumbaimerijaan commented 6 years ago

Stop not working... When I checked I found that all timeouts are not removed, hence when reloading the page in the iframe I am getting an error.

To solve this, I passed the timeout id to the function called in setTimeout, and then cleared the timeout promptly. Please make this change to the original code, so that others will be benefited.

blaiprat commented 6 years ago

Hi @mumbaimerijaan , thanks for opening the issue.

Since it's Christmas I might not have enough free time, do you mind providing a PR for this code please?

Thanks!

mumbaimerijaan commented 6 years ago

Sorry am new to github.. what's a PR?

Regards, Sachin

On Dec 6, 2017 7:29 PM, "Blai Pratdesaba" notifications@github.com wrote:

Hi @mumbaimerijaan https://github.com/mumbaimerijaan , thanks for opening the issue.

Since it's Christmas I might not have enough free time, do you mind providing a PR for this code please?

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/blaiprat/jquery.animateSprite/issues/14#issuecomment-349647460, or mute the thread https://github.com/notifications/unsubscribe-auth/AHIiqrtr4Qvjc5lbI9iyy6Mhz_FfR6RHks5s9p2lgaJpZM4Q2hRt .

CorentinVv commented 6 years ago

Hey ! Thank you for your script ! Loop and autoplay are not working for me, do you know how to solve this please ?

Regards.

CorentinVv commented 6 years ago

Sorry am new to github.. what's a PR? Regards, Sachin On Dec 6, 2017 7:29 PM, "Blai Pratdesaba" @.***> wrote: Hi @mumbaimerijaan https://github.com/mumbaimerijaan , thanks for opening the issue. Since it's Christmas I might not have enough free time, do you mind providing a PR for this code please? Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14 (comment)>, or mute the thread https://github.com/notifications/unsubscribe-auth/AHIiqrtr4Qvjc5lbI9iyy6Mhz_FfR6RHks5s9p2lgaJpZM4Q2hRt .

PR is a pull request