search

blairconrad / SelfInitializingFakes

Like Fowler's self-initializing fakes.
MIT License
11 stars 3 forks source link

Fix FakeItEasy dependency in nupkg #2

Closed blairconrad closed 7 years ago

blairconrad commented 7 years ago

We're using rc001 in the build and the package has a dependency on beta002

adamralph commented 7 years ago

Dropping the nuspec munging is the right thing to do. It's only required when you need to pack two or more projects with dependencies between them.

Why are you using FakeItEasy's version number?

blairconrad commented 7 years ago

Why are you using FakeItEasy's version number?

It's the FakeItEasy dependency I'm shoving into the nupkg.

blairconrad commented 7 years ago

@adamralph, you may have been confused because I somehow neglected to upload my nuspec, which had been reverted on disk. Good thing emacs had a copy in memory!

blairconrad commented 7 years ago

Wow, I didn't even know it was possible to parse JSON as XML.

Me neither! In particular, I didn't know that there was a framework-provided way to read JSON. I've taken your advice and made the path to the version node explicit.

adamralph commented 7 years ago

@adamralph, you may have been confused because I somehow neglected to upload my nuspec, which had been reverted on disk. Good thing emacs had a copy in memory!

👍 that makes sense now. That is actually a very nice way to avoid having to manually maintain the version range. I'm going to steal this idea!

blairconrad commented 7 years ago

Thanks, @adamralph. After the version mismatch here, and the one we'd had in FakeItEasy a little while back, I realized that humans can't be trusted.

blairconrad commented 7 years ago

Parameterized the method, as seen in Automatically Sync nupkg and project.json Dependencies. Would y'all prefer if I just kept merging things on my own instead of relying on you for merges? I'm happy either way.

thomaslevesque commented 7 years ago

Would y'all prefer if I just kept merging things on my own instead of relying on you for merges? I'm happy either way.

Me too. It's your project, so I think it makes sense for you to merge yourself when you feel it's ready. We can still do reviews, which you're free to heed or ignore :wink:

blairconrad commented 7 years ago

Okay, @thomaslevesque. Thanks. I'll adjust so I can self-merge. At some point we may want to consider pulling under the FakeItEasy umbrella (unless I misunderstood previous conversations) but until then, I'll act as if it's mine. Also, thanks for the review!

blairconrad commented 7 years ago

until then

or until either of you expresses interest in a more involved role!

thomaslevesque commented 7 years ago

At some point we may want to consider pulling under the FakeItEasy umbrella (unless I misunderstood previous conversations)

👍

I'm looking at the rest of the code to get more familiar with it.