search

blairconrad / SelfInitializingFakes

Like Fowler's self-initializing fakes.
MIT License
11 stars 3 forks source link

[WIP] Convert Task and Lazys so they can be (de)serialized #86

Open blairconrad opened 4 years ago

blairconrad commented 4 years ago

Fixes #81.

This solution is independent of serializers, and supports Tasks, Tasks<T>s, and Lazy<T>s, including any (directly) nested combinations of these, e.g. Lazy<Task<T>>. However, these are only supported as the "top": as a direct return value, or out or ref parameter. A List<Task<T>> would not be handled.

blairconrad commented 4 years ago

@CableZa, I think this pull request will satisfy your requirement for recording and playing back a Task-returning method. In particular, I added a test case for a Task<int>, which seemed quite similar to the test you added to #79. Are you interested in taking a look? Trying it out? I could release an -alpha, if it makes it easier.

CableZa commented 4 years ago

Awesome @blairconrad, I will check this out!

blairconrad commented 3 years ago

Hey, @CableZa. Any feedback? Did it work out for you? Not work out for you?

CableZa commented 2 years ago

Hey @blairconrad, sorry for taking close on a year for responding. Though this does look like it would cover what I was keen for at the time, I ended up taking a different strategy regarding testing and test doubles.

Thanks so much for taking the time, I have learned a lot from looking through the code in SelfInitializingFakes, as well the response to my initial PR. I have a much better understanding of developing cross framework/core libraries, as well as the expectations and process of contributing to OSS projects.

Till the next time, cheers!

blairconrad commented 2 years ago

Thanks so much for taking the time, I have learned a lot from looking through the code in SelfInitializingFakes, as well the response to my initial PR. I have a much better understanding of developing cross framework/core libraries, as well as the expectations and process of contributing to OSS projects.

Hey, @CableZa. Good to hear from you. While I'm sorry that you were never able to take advantages of the changes in this pull request, I'm very glad that you found value in the exchange. Happy OSSing.