blairj09 / cryptor

An R wrapper for the CryptoCompare API.
https://blairj09.github.io/cryptor
Other
7 stars 6 forks source link

Deprecated/removed parameters in endpoint causing issues #3

Closed Lauler closed 4 years ago

Lauler commented 5 years ago

First off: nice package thanks for developing it!

A number of the parameters in your get_historical_price()-function have been deprecated or removed from the API endpoint. Some of them are causing issues (downloading the entirety of the historical data in spite of setting a limit).

In particular it's the tryConversion = tolower(try_conversion) argument in get_historical_price() whose inclusion overrides the limit argument. I'd recommend removing that argument/parameter.

You could probably also remove allData argument as it does not seem to do anything.