search

blairjordan / pianoboi

🎹 A desktop app for displaying live sheet music from MIDI input.
MIT License
99 stars 22 forks source link

Highlight notes that are sustained with pedal #5

Open wmedrano opened 5 years ago

wmedrano commented 5 years ago

If a note is released and the sustain pedal is active, maybe the key can be half-highlighted?

blairjordan commented 5 years ago

@wmedrano At the moment, the notes will disappear when you release them I'm guessing? (can't test this right now).

It looks like when the velocity of a key is 0, I remove it from the pressed keys array. The sustain pedal is sent through as a separate message, so I could maintain a separate array of pressed keys when sustain is pressed, and clear it when the pedal is released and the key is released.

That way it's possible to style it separately. Very doable. I'll have a look at this next time I make modifications.

wmedrano commented 5 years ago

Feel free to assign any issues I file to myself.