search

blairjordan / pianoboi

🎹 A desktop app for displaying live sheet music from MIDI input.
MIT License
98 stars 22 forks source link

Notes are duplicated in Bass and Treble Clef #6

Closed wmedrano closed 5 years ago

wmedrano commented 5 years ago

Is this intended behavior? Would it be feasible to merge the clefs so that they share middle C?

blairjordan commented 5 years ago

@wmedrano Probably not intended by design, more likely laziness (just feeding keys into vexflow).

I don't see an issue with merging them off the top of my head, so I'll have a play around with this.

Thinking out loud, bass stave just needs to be raised, split keys array into two (between B/C) and feed these to treble/bass separately. Treble clef size would need to be reduced also. Possibly more to it but I can give it a try.

blairjordan commented 5 years ago

Commit 9b3bccf resolves this issue.